-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update explainer-recursion.md #3906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made some simple readability changes
kevaundray
changed the title
Update explainer-recursion.md
chore: Update explainer-recursion.md
Dec 21, 2023
dbanks12
approved these changes
Dec 21, 2023
TomAFrench
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🌾
TomAFrench
added a commit
that referenced
this pull request
Dec 28, 2023
* master: chore: Optimize goto_definitions for workspace case (#3914) chore: Update index.md (#3911) chore: Update index.md (#3910) chore: Update how-to-recursion.md (#3912) feat: Resolve oracle calls via JSON-RPC (#3902) chore: Update explainer-recursion.md (#3906) chore: remove unnecessary dependency (#3901) chore: improve package.json metadata (#3900) feat: prefer `AcirContext`-native methods for performing logic operations (#3898) feat: optimize logic gate ACIR-gen (#3897) fix: allow abi encoding tuples from JS (#3894) chore: error on cspell issues in docs (#3886)
TomAFrench
added a commit
that referenced
this pull request
Jan 3, 2024
* master: (48 commits) chore: fix broken links (#3935) chore: updated ACIR documentation and other docs (#3932) chore: rename "syntax" chapter in docs to "concepts" (#3934) fix: checks for cyclic dependencies (#3699) fix(debugger): crash when stepping through locations spanning multiple lines (#3920) chore: abstract away subtractions from `OR` implementation (#3923) chore: fix `should_fail_mismatch` test to use correct pedersen return type (#3927) fix: prevent `Instruction::Constrain`s for non-primitive types (#3916) feat: remove unnecessary predicate from `Lt` instruction (#3922) feat: simplify multiplications by `0` or `1` in ACIR gen (#3924) chore: bump dependency versions (#3925) chore: Update CONTRIBUTING.md (#3921) chore: Optimize goto_definitions for workspace case (#3914) chore: Update index.md (#3911) chore: Update index.md (#3910) chore: Update how-to-recursion.md (#3912) feat: Resolve oracle calls via JSON-RPC (#3902) chore: Update explainer-recursion.md (#3906) chore: remove unnecessary dependency (#3901) chore: improve package.json metadata (#3900) ...
AztecBot
pushed a commit
that referenced
this pull request
Jan 17, 2024
Changes the output of `nargo` and `noir-wasm` to generate a single artifact that includes debug information. Compiled contracts now have a `file_map` at the root of the artifact, and a `debug_symbols` within each function. For consistency, compiled programs also have `file_map` and `debug_symbols`. Debug symbols are compressed and base64-encoded, as they were by the former `noir-compiler` postprocessing. The `debug` json artifact is no longer emitted. Removes all code related to generating `yarn-project`-specific ABIs from noir compiler. Instead, `types` now exposes a `loadContractArtifact` that renames fields as needed (and use camel instead of snake case), and is required when loading a noir contract artifact. Autogenerated types run this automatically. Since we are no longer post-processing artifacts, the `noir-contracts` project shape is changed. JSON files live in the `target` folder where nargo outputs them (this is not configurable), and are loaded by the autogenerated typescript interfaces from there. As part of the refactor, moves functions for getting functions debug info out of `acir-simulator` and into `types`. **Breaking change**: This removes the need to run `codegen` for using a compiled contract. However, when creating a new contract object from aztec.js, a dev needs to call `loadContractArtifact`. **Future changes**: Type information for a compilation artifact is now spread all over the place, and duplicated in more than one place. There are types defined within rust code in Noir as `[wasm_bindgen(typescript_custom_section)]`, others defined within typescript code in the `noir_wasm` package, others in `foundation`, and others in `types`. We should unify it in a single place. Fixes AztecProtocol/aztec-packages#3812 Supersedes #3906 Noir subrepo has been pushed to #4035 to run the Noir CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some simple readability changes
Description
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.